Report any technical problems you discover and discuss solutions.

New base template, default engine = flash

r.j.
Topic Author
Offline
Junior Member

10 years 1 month ago - 10 years 1 month ago #3786 by r.j.

New base template, default engine = flash was created by r.j.

When adding a new template (as in Nottingham variant), method found here , i find that every new LO template added gets the flash default engine..

I guess this is due to line 69 a.f. of /website_code/php/templates/new_template.php (see below).
Is there a reason to only make javascript default with templates named Nottingham and not every template of the type xerte?

/

Code:

*
 * create the new template record in the database
 */
$extraflags = "";
if ($row_template_type['template_framework'] == 'xerte')
{
    if ($row_template_type['template_name'] == 'Nottingham')
    {
        $extraflags = "engine=javascript";
    }
    else
    {
        $extraflags = "engine=flash";
    }
}

Last edit: 10 years 1 month ago by r.j..

Please Log in or Create an account to join the conversation.

JohnSmith
Offline
Moderator

10 years 1 month ago #3787 by JohnSmith

Replied by JohnSmith on topic New base template, default engine = flash

Hi,

Those instructions are 2 1/2 years old and perhaps requiring some updating. The reason for extraflags = flash for all the non-Nottingham templates is because of legacy mediaInteractions and multipersp templates ( github.com/thexerteproject/xerteonlineto...8536070692bd6df9b233 ) which descend from Xerte but do not play in the new javascript/HTML5 player.

Perhaps it would be better to check for these rather than 'Nottingham' and flip the logic:

Code:

*
 * create the new template record in the database
 */
$extraflags = "";
if ($row_template_type['template_framework'] == 'xerte')
{
    if ( ($row_template_type['template_name'] == 'multipersp') ||
        ($row_template_type['template_name'] == 'mediaInteractions') ||
        ($row_template_type['template_name'] == 'Rss') )
    {
        $extraflags = "engine=flash";
    }
    else
    {
        $extraflags = "engine=javascript";
    }
}

The following user(s) said Thank You: r.j.

Please Log in or Create an account to join the conversation.

r.j.
Topic Author
Offline
Junior Member

10 years 1 month ago #3788 by r.j.

Replied by r.j. on topic New base template, default engine = flash

Far better, thanks!

Did you already commit this on github?

Please Log in or Create an account to join the conversation.

JohnSmith
Offline
Moderator

10 years 1 month ago #3789 by JohnSmith

Replied by JohnSmith on topic New base template, default engine = flash

Nope just came up with it but I can do if you are happy that it is better?

Please Log in or Create an account to join the conversation.

JohnSmith
Offline
Moderator

10 years 1 month ago #3790 by JohnSmith

Replied by JohnSmith on topic New base template, default engine = flash

That's it committed to Github.

Please Log in or Create an account to join the conversation.

Moderators: ronm, julten, JohnSmith

Time to create page: 0.166 seconds

New base template, default engine = flash

Main Pages

Quick Links

Support

External resources